add TCK tests for auto-closeable beans (@AutoClose)#709
Conversation
|
This is no longer a draft
Other than that, it should be fine. Submitting it now for @manovotn's ongoing work. |
|
Added tests for |
|
Added a test that the call to The commits in this PR could be squashed, but don't necessarily have to be; I don't mind. |
|
Rebased, this can be merged now as there's no |
|
Added one more commit that tests that auto-closeable dependent objects are closed when the containing bean is destroyed. |
Azquelt
left a comment
There was a problem hiding this comment.
Looks good 👍
I don't think we ever actually assert that isAutoClose() returns false anywhere, that may be worth adding.
|
Good point, we test both for |
|
Added an extra commit with tests for |
|
I think we can merge this now - @Ladicek, I assume you want to squash those commits first? |
|
I didn't merge this because of the ongoing discussion in jakartaee/cdi#968, but I guess we can merge anyway, because the spec was already merged too. Let me squash the commits and merge. |
Fixes #700